zf

zenflows testing
git clone https://s.sonu.ch/~srfsh/zf.git
Log | Files | Refs | Submodules | README | LICENSE

commit 2ea01da70e8570b6ab9a1d8c2920c20c8856739e
parent f12d37c6b3ef67a91589edbe9c7af565c1e3994c
Author: srfsh <dev@srf.sh>
Date:   Tue, 13 Dec 2022 20:56:00 +0300

Zenflows{,Test}.VF.Proposal: rename state to status

Diffstat:
Msrc/zenflows/vf/proposal/domain.ex | 8++++----
Msrc/zenflows/vf/proposal/query.ex | 4++--
Msrc/zenflows/vf/proposal/resolv.ex | 4++--
Msrc/zenflows/vf/proposal/type.ex | 8++++----
Mtest/vf/proposal/domain.test.exs | 8++++----
5 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/src/zenflows/vf/proposal/domain.ex b/src/zenflows/vf/proposal/domain.ex @@ -52,11 +52,11 @@ def all!(page \\ Page.new()) do value end -@spec state(Proposal.t() | Schema.id()) +@spec status(Proposal.t() | Schema.id()) :: {:ok, :pending | :accepted | :refused} | {:error, String.t()} -def state(%Proposal{id: id}), do: state(id) -def state(id) do - Query.state(id) +def status(%Proposal{id: id}), do: status(id) +def status(id) do + Query.status(id) |> Repo.one() |> case do nil -> {:error, "not found"} diff --git a/src/zenflows/vf/proposal/query.ex b/src/zenflows/vf/proposal/query.ex @@ -172,8 +172,8 @@ defp all_validate(params) do |> Changeset.apply_action(nil) end -@spec state(Schema.id()) :: Queryable.t() -def state(id) do +@spec status(Schema.id()) :: Queryable.t() +def status(id) do from p in Proposal, where: p.id == ^id, join: pi in assoc(p, :publishes), diff --git a/src/zenflows/vf/proposal/resolv.ex b/src/zenflows/vf/proposal/resolv.ex @@ -94,7 +94,7 @@ def reciprocal_intents(prop, _, _) do {:ok, prop.reciprocal_intents} end -def state(prop, _, _) do - {:ok, Domain.state(prop)} +def status(prop, _, _) do + {:ok, Domain.status(prop)} end end diff --git a/src/zenflows/vf/proposal/type.ex b/src/zenflows/vf/proposal/type.ex @@ -37,8 +37,8 @@ create commitments; commonly seen in a price list or e-commerce. @eligible_location "The location at which this proposal is eligible." @eligible_location_id "(`SpatialThing`) #{@eligible_location}" -@desc "The state of the proposal: pending, accepted, or refused." -enum :proposed_state do +@desc "The status of the proposal: pending, accepted, or refused." +enum :proposed_status do value :pending value :accepted value :refused @@ -80,8 +80,8 @@ object :proposal do field :reciprocal_intents, list_of(non_null(:intent)), resolve: &Resolv.reciprocal_intents/3 - field :state, non_null(:proposed_state), - resolve: &Resolv.state/3 + field :status, non_null(:proposed_status), + resolve: &Resolv.status/3 end input_object :proposal_create_params do diff --git a/test/vf/proposal/domain.test.exs b/test/vf/proposal/domain.test.exs @@ -48,24 +48,24 @@ describe "one/1" do end end -describe "state/1" do +describe "status/1" do test "pending", %{inserted: proposal} do int = Factory.insert!(:intent, finished: false) Factory.insert!(:proposed_intent, published_in: proposal, publishes: int) - assert {:ok, :pending} = Domain.state(proposal.id) + assert {:ok, :pending} = Domain.status(proposal.id) end test "accepted", %{inserted: proposal} do int = Factory.insert!(:intent, finished: false) Factory.insert!(:proposed_intent, published_in: proposal, publishes: int) Factory.insert!(:satisfaction, satisfies: int) - assert {:ok, :accepted} = Domain.state(proposal.id) + assert {:ok, :accepted} = Domain.status(proposal.id) end test "refused", %{inserted: proposal} do int = Factory.insert!(:intent, finished: true) Factory.insert!(:proposed_intent, published_in: proposal, publishes: int) - assert {:ok, :refused} = Domain.state(proposal.id) + assert {:ok, :refused} = Domain.status(proposal.id) end end